Fixed bug #61 and added unit test

2 files changed, 27 insertions, 9 deletions

diff --git a/src/core/common/VariantReader.cpp b/src/core/common/VariantReader.cpp
index fb93ad0..601d086 100644
--- a/src/core/common/VariantReader.cpp
+++ b/src/core/common/VariantReader.cpp
@@ -848,17 +848,23 @@ std::pair<bool, Variant> VariantReader::parseGenericToken(
 std::pair<bool, Variant> VariantReader::parseGenericString(
     const std::string &str, Logger &logger, SourceId sourceId, size_t offs)
 {
-	CharReader reader{str, sourceId, offs};
-	LoggerFork loggerFork = logger.fork();
+	// If the given string is empty, just return it as a string (there is no
+	// other type for which something empty would be valid)
+	// TODO: How to integrate this into parseGenericToken?
+	if (!str.empty()) {
+		CharReader reader{str, sourceId, offs};
+		LoggerFork loggerFork = logger.fork();
 
-	// Try to parse a single token
-	std::pair<bool, Variant> res =
-	    parseGenericToken(reader, loggerFork, std::unordered_set<char>{}, true);
+		// Try to parse a single token
+		std::pair<bool, Variant> res = parseGenericToken(
+		    reader, loggerFork, std::unordered_set<char>{}, true);
 
-	// If the string was actually consisted of a single token, return that token
-	if (reader.atEnd()) {
-		loggerFork.commit();
-		return res;
+		// If the string was actually consisted of a single token, return that
+		// token
+		if (reader.atEnd()) {
+			loggerFork.commit();
+			return res;
+		}
 	}
 
 	// Otherwise return the given string as a string, set the location of the
diff --git a/test/core/common/VariantReaderTest.cpp b/test/core/common/VariantReaderTest.cpp
index a23af09..79e567b 100644
--- a/test/core/common/VariantReaderTest.cpp
+++ b/test/core/common/VariantReaderTest.cpp
@@ -1153,6 +1153,18 @@ TEST(VariantReader, parseGenericString)
 		ASSERT_EQ(0U, loc.getStart());
 		ASSERT_EQ(15U, loc.getEnd());
 	}
+
+	// Parse empty string
+	{
+		auto res = VariantReader::parseGenericString("", logger);
+		ASSERT_TRUE(res.first);
+		ASSERT_TRUE(res.second.isString());
+		ASSERT_EQ("", res.second.asString());
+
+		SourceLocation loc = res.second.getLocation();
+		ASSERT_EQ(0U, loc.getStart());
+		ASSERT_EQ(0U, loc.getEnd());
+	}
 }
 
 TEST(VariantReader, parseGenericComplex)