diff options
| author | Andreas Stöckel <astoecke@techfak.uni-bielefeld.de> | 2014-12-12 02:15:45 +0100 |
|---|---|---|
| committer | Andreas Stöckel <astoecke@techfak.uni-bielefeld.de> | 2014-12-12 02:15:45 +0100 |
| commit | 58b0dcbaabb36df43b4bfa4c74a963d8b24a54fe (patch) | |
| tree | a8f3434605966abd1986dd40346102f5d2db3e78 | |
| parent | 8384132e9f8d70c0d23cb1c37e51b064405a1a6d (diff) | |
fixed bug in Utils::isIdentifier and added regression test
| -rw-r--r-- | src/core/common/Utils.cpp | 2 | ||||
| -rw-r--r-- | test/core/common/UtilsTest.cpp | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/src/core/common/Utils.cpp b/src/core/common/Utils.cpp index c460ed4..5eaafe9 100644 --- a/src/core/common/Utils.cpp +++ b/src/core/common/Utils.cpp @@ -48,7 +48,7 @@ bool Utils::isIdentifier(const std::string &name) if (first && !(isAlphabetic(c) || c == '_')) { return false; } - if (first && !(isAlphanumeric(c) || c == '_' || c == '-')) { + if (!first && !(isAlphanumeric(c) || c == '_' || c == '-')) { return false; } first = false; diff --git a/test/core/common/UtilsTest.cpp b/test/core/common/UtilsTest.cpp index 2858038..66458b2 100644 --- a/test/core/common/UtilsTest.cpp +++ b/test/core/common/UtilsTest.cpp @@ -29,6 +29,7 @@ TEST(Utils, isIdentifier) ASSERT_TRUE(Utils::isIdentifier("_t0-_EST")); ASSERT_FALSE(Utils::isIdentifier("-t0-_EST")); ASSERT_FALSE(Utils::isIdentifier("0t-_EST")); + ASSERT_FALSE(Utils::isIdentifier("invalid key")); } TEST(Utils, trim) |